-
-
Notifications
You must be signed in to change notification settings - Fork 215
Fix CI #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix CI #342
Conversation
|
@sfackler ping |
Lekensteyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actions/cache upgrade is mandatory to fix this CI failure identified while working on #341:
This request has been automatically failed because it uses a deprecated version of
actions/cache: v1. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
The security_framework fix is needed to address this CI failure:
Run cargo test --features vendored
cargo test --features vendored
shell: /bin/bash -e {0}
env:
RUSTFLAGS: -Dwarnings
RUST_BACKTRACE: 1
Compiling libc v0.2.177
Compiling rustix v1.1.2
Compiling bitflags v2.9.4
Compiling getrandom v0.3.4
Compiling core-foundation-sys v0.8.7
Compiling regex-syntax v0.8.8
Compiling once_cell v1.21.3
Compiling cfg-if v1.0.4
Compiling fastrand v2.3.0
Compiling errno v0.3.14
Compiling core-foundation v0.9.4
Compiling security-framework-sys v2.15.0
Compiling regex-automata v0.4.13
Compiling tempfile v3.23.0
Compiling base64 v0.13.1
Compiling native-tls v0.2.14 (/Users/runner/work/rust-native-tls/rust-native-tls)
Compiling security-framework v2.11.1
Compiling regex v1.12.2
Compiling pem v0.8.3
Compiling test-cert-gen v0.9.0
Finished `test` profile [unoptimized + debuginfo] target(s) in 14.55s
Running unittests src/lib.rs (target/debug/deps/native_tls-58f9417dc5ec2f07)
running 17 tests
test test::connect_bad_hostname_ignored ... ok
test test::certificate_from_pem ... ok
test test::connect_bad_hostname ... ok
test test::connect_no_root_certs ... ok
test test::from_pkcs8_rejects_rsa_key ... ok
test test::connect_google ... ok
test test::server ... ok
test test::server_no_root_certs ... ok
test test::server_no_shared_protocol ... ok
test test::import_same_identity_multiple_times ... ok
test test::server_pkcs8 ... ok
test test::server_tls11_only ... ok
test test::server_untrusted ... ok
test test::server_untrusted_unverified ... ok
test test::shutdown ... ok
test test::peer_certificate ... FAILED
test test::two_servers ... ok
failures:
---- test::peer_certificate stdout ----
thread 'test::peer_certificate' panicked at src/test.rs:165:20:
Error { code: -25299, message: "The specified item already exists in the keychain." }
stack backtrace:
0: rust_begin_unwind
at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library/std/src/panicking.rs:652:5
1: core::panicking::panic_fmt
at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library/core/src/panicking.rs:72:14
2: native_tls::test::peer_certificate
at ./src/test.rs:14:23
3: native_tls::test::peer_certificate::{{closure}}
at ./src/test.rs:162:22
4: core::ops::function::FnOnce::call_once
at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library/core/src/ops/function.rs:250:5
5: core::ops::function::FnOnce::call_once
at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
test::peer_certificate
test result: FAILED. 16 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.96s
Actions update + a smaller fix for #337